lkml.org 
[lkml]   [2013]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/15] sched: Reschedule task on preferred NUMA node once selected
On Sat, Jul 06, 2013 at 12:08:53AM +0100, Mel Gorman wrote:
> +static int
> +find_idlest_cpu_node(int this_cpu, int nid)
> +{
> + unsigned long load, min_load = ULONG_MAX;
> + int i, idlest_cpu = this_cpu;
> +
> + BUG_ON(cpu_to_node(this_cpu) == nid);
> +
> + rcu_read_lock();
> + for_each_cpu(i, cpumask_of_node(nid)) {
> + load = weighted_cpuload(i);
> +
> + if (load < min_load) {
> + /*
> + * Kernel threads can be preempted. For others, do
> + * not preempt if running on their preferred node
> + * or pinned.
> + */
> + struct task_struct *p = cpu_rq(i)->curr;
> + if ((p->flags & PF_KTHREAD) ||
> + (p->numa_preferred_nid != nid && p->nr_cpus_allowed > 1)) {
> + min_load = load;
> + idlest_cpu = i;
> + }

So I really don't get this stuff.. if it is indeed the idlest cpu preempting
others shouldn't matter. Also, migrating a task there doesn't actually mean it
will get preempted either.

In overloaded scenarios it expected that multiple tasks will run on the same
cpu. So this condition will also explicitly make overloaded scenarios work less
well.

> + }
> + }
> + rcu_read_unlock();
> +
> + return idlest_cpu;
> +}


\
 
 \ /
  Last update: 2013-07-06 13:21    [W:0.097 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site