Messages in this thread | | | Date | Fri, 5 Jul 2013 14:08:30 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH V4 15/21] perf tools: fix missing increment in sample parsing |
| |
Em Thu, Jul 04, 2013 at 04:20:34PM +0300, Adrian Hunter escreveu: > The final sample format bit used to be PERF_SAMPLE_STACK_USER > which neglected to do a final increment of the array pointer. > The result is that the following parsing might start at the > wrong place.
One 'perf test' entry that would ask for these features and then check that the result obtained is what is expected would come in handy here :-\
- Arnaldo
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > --- > tools/perf/util/evsel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 86628fe..10ccf38 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -1284,7 +1284,7 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event, > } else { > data->user_stack.data = (char *)array; > array += size / sizeof(*array); > - data->user_stack.size = *array; > + data->user_stack.size = *array++; > } > } > > -- > 1.7.11.7
| |