Messages in this thread | | | Date | Fri, 5 Jul 2013 07:58:49 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [URGENT rfc patch 0/3] tsc clocksource bug fix |
| |
On Fri, 5 Jul 2013, Alex Shi wrote: > On 07/05/2013 04:27 AM, Thomas Gleixner wrote: > >>>> We find some benchmarks drop a lot on tip/sched/core on many Intel boxes, > > And that branch does NOT have that commit included. So how can you see > > a regression on a branch caused by a commit NOT included into that > > branch? > > > > The offending commit is in tip timers/core and not in tip > > sched/core. What I'm wanted to say is, that we need a proper > > description of problems and not some random association. > > > > It tricked you to assume, that I'm not able to figure it out myself :) > > > > See? These things are complex and subtle, so we need precise > > descriptions and not some sloppy semi correct data. > > > > I'm well aware of the issue and with Peters help I got a reasonable > > explanation for it. A proper fix is about to be sent out. > > > > Ingo had merged your branch into sched/core. :) > > commit f9bed7021710a3e45c331f7d7781de914cc1b939 > Merge: 7e76057 67dd331 > Author: Ingo Molnar <mingo@kernel.org> > Date: Wed May 29 11:21:59 2013 +0200 > > Merge branch 'timers/urgent'
Not really.
tip$ git branch --contains f9bed70217 * master
tip$ git branch --contains 5d33b883ae * master timers/core
So you are testing tip/master not tip/sched/core.
Thanks,
tglx
| |