lkml.org 
[lkml]   [2013]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] mm: Honor min_free_kbytes set by user
On Thu 04-07-13 09:10:39, Joe Perches wrote:
> On Thu, 2013-07-04 at 18:07 +0200, Michal Hocko wrote:
> > A warning is printed when the new value is ignored.
>
> []
>
> > + printk(KERN_WARNING "min_free_kbytes is not updated to %d"
> > + "because user defined value %d is preferred\n",
> > + new_min_free_kbytes, user_min_free_kbytes);
>
> Please use pr_warn and coalesce the format.

Sure can do that. mm/page_alloc.c doesn't seem to be unified in that
regards (44 printks and only 4 pr_<foo>) so I used printk.

> You'd've noticed a missing space between %d and because.

True

Thanks
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2013-07-04 19:01    [W:0.184 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site