Messages in this thread | | | Date | Thu, 4 Jul 2013 19:09:05 +0530 | From | Sekhar Nori <> | Subject | Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable |
| |
On 7/4/2013 5:03 PM, Sebastian Andrzej Siewior wrote: > On 07/04/2013 01:14 PM, Sekhar Nori wrote: >> >> On 6/11/2013 5:00 PM, Sebastian Andrzej Siewior wrote: >>> From: "Patil, Rachna" <rachna@ti.com> >>> >>> The current driver expected touchscreen input >>> wires(XP,XN,YP,YN) to be connected in a particular order. >>> Making changes to accept this as platform data >> >> The platform data part of this driver will never get used since it is >> used on DT-only platforms (and future platforms will all be DT-only). >> You should get rid of it as it will save you some code. > > If you follow the series you will notice that the platform bits are > removed later. Should I have overlooked something please say so.
Yes, I noticed that after sending the mail. To me it does not make sense to make changes to accept something as platform data only to remove platform data itself later.
May be reorder the series to move this to after platform data removal - that way any platform data related changes in the patch will have to go away.
Thanks, Sekhar
| |