lkml.org 
[lkml]   [2013]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/9] perf tools: Enhance and correct srcline behavior
Date
Hello,

This patchset tries to fix and enhance current srcline behavior.

Firstly it doesn't actually sort by srcline info but by ip. I suspect
it was because of a performance reason to run external addr2line
utility. It showed the srcline info after hist entries were
collapsed. Thanks to Roberto, we now have internal implementation of
addr2line using libbfd so can sort/compare by srcline of entries.

Second problem for me was it sometimes printed "??:0" and sometimes
printed a raw ip value for unknown srcline info. I changed to print
the former consistently.

While at it, I found some bugs/leaks in srcline handling. Patch 1-3
are fixes for those and can be merged separately.

You can get this series on my 'perf/srcline-v1' branch in my tree at:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks.
Namhyung


Namhyung Kim (8):
perf sort: Fix a memory leak on srcline
perf annotate: Reuse path from the result of addr2line
perf hists: Free srcline when freeing hist_entry
perf tools: Factor out get/free_srcline()
perf tools: Do not try to call addr2line for non-binary files
perf tools: Pass dso instead of dso_name to get_srcline()
perf tools: Save failed result of get_srcline()
perf tools: Fix srcline sort key behavior

Roberto Vitillo (1):
perf tools: Implement addr2line directly using libbfd

tools/perf/Makefile | 1 +
tools/perf/config/Makefile | 4 +
tools/perf/util/annotate.c | 33 +-----
tools/perf/util/dso.c | 1 +
tools/perf/util/dso.h | 2 +
tools/perf/util/hist.c | 1 +
tools/perf/util/sort.c | 58 ++++------
tools/perf/util/srcline.c | 265 +++++++++++++++++++++++++++++++++++++++++++++
tools/perf/util/util.h | 8 ++
9 files changed, 308 insertions(+), 65 deletions(-)
create mode 100644 tools/perf/util/srcline.c

--
1.7.11.7



\
 
 \ /
  Last update: 2013-08-01 06:21    [W:1.203 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site