Messages in this thread | | | From | Namhyung Kim <> | Date | Thu, 1 Aug 2013 11:32:52 +0900 | Subject | Re: [PATCH V2 1/9] perf tools: add test for reading object code |
| |
Hi Peter,
On Wed, Jul 31, 2013 at 11:24 PM, Peter Zijlstra <peterz@infradead.org> wrote: > On Wed, Jul 31, 2013 at 11:17:32AM -0300, Arnaldo Carvalho de Melo wrote: >> Em Wed, Jul 31, 2013 at 12:13:50AM +0300, Adrian Hunter escreveu: >> > Using the information in mmap events, perf tools can read object >> > code associated with sampled addresses. A test is added that >> > compares bytes read by perf with the same bytes read using >> > objdump. >> >> So this parses objdump output, and we also already have the annotation >> logic that does that too, have you thought about having common routines >> for these two cases? >> > > Or better yet, stop using objdump like this and start using libbfd > directly. The only reason we did horrible things like parsing objdump > output is because nobody knew how the underlying stuff actually worked > and we wanted to have something quick.
I have similar patch for getting srcline info (using addr2line) based on Roberto Vitillo's patch. I'll send the series soon and then look at the objdump too.
-- Thanks, Namhyung Kim
| |