lkml.org 
[lkml]   [2013]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/18] mm, hugetlb: do hugepage_subpool_get_pages() when avoid_reserve
    On Wed, Jul 31, 2013 at 02:02:50PM +0900, Joonsoo Kim wrote:
    > On Mon, Jul 29, 2013 at 02:05:51PM -0400, Naoya Horiguchi wrote:
    > > On Mon, Jul 29, 2013 at 02:31:59PM +0900, Joonsoo Kim wrote:
    > > > When we try to get a huge page with avoid_reserve, we don't consume
    > > > a reserved page. So it is treated like as non-reserve case.
    > >
    > > This patch will be completely overwritten with 9/18.
    > > So is this patch necessary?
    >
    > Yes. This is a bug fix, so should be separate.
    > When we try to allocate with avoid_reserve, we don't use reserved page pool.
    > So, hugepage_subpool_get_pages() should be called and returned if failed.
    >
    > If we merge these into one, we cannot know that there exists a bug.

    OK, so you can merge this with the subpool accounting fix in 6/18
    as one fix.

    Thanks,
    Naoya


    \
     
     \ /
      Last update: 2013-07-31 23:21    [W:4.628 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site