lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 6/8] wlcore: sdio: add wilink clock providers
Date
Quoting Luciano Coelho (2013-07-30 06:04:34)
> +static const struct of_device_id wlcore_sdio_of_clk_match_table[] = {
> + { .compatible = "ti,wilink-clock" },
> +};
> +
> static struct wl12xx_platform_data *wlcore_get_pdata_from_of(struct device *dev)
> {
> struct wl12xx_platform_data *pdata;
> struct device_node *np = dev->of_node;
> + struct device_node *clock_node;
>
> if (!np) {
> np = of_find_matching_node(NULL, dev->driver->of_match_table);
> @@ -241,6 +247,9 @@ static struct wl12xx_platform_data *wlcore_get_pdata_from_of(struct device *dev)
> goto out_free;
> }
>
> + for_each_matching_node(clock_node, wlcore_sdio_of_clk_match_table)
> + of_fixed_clk_setup(clock_node);

Hi Luciano,

Any reason for establishing your own compatible string if you just plan
to use the fixed rate clock? You could just use "fixed-clock" compatible
in your DTS.

I will be posting patches this week which makes the fixed-rate clock a
proper driver and matches that compatible string to instantiate those
clocks. That means that your driver could probably remove the clock
setup code completely.

Regards,
Mike

> +
> goto out;
>
> out_free:
> --
> 1.8.3.2


\
 
 \ /
  Last update: 2013-07-31 01:01    [W:0.158 / U:12.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site