Messages in this thread | | | Date | Tue, 30 Jul 2013 17:52:12 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 0/8] perf: add ability to sample physical data addresses |
| |
On Tue, Jul 30, 2013 at 04:21:41PM +0200, Stephane Eranian wrote: > Peter, > > One thing that bothers me with the MMAP2 approach is that > it forces integration into perf.
This is a good (TM) thing, yes? ;-)
> Now, you will need to analyze > the MMAP2 records. With my sample_type approach, you > simply needed a cmdline option on perf record, and then > you could dump the sample using perf report -D and feed > them into a post-processing script. But now, the analysis > needs to be integrated into perf or the tool needs to parse > the full perf.data file.
So the disadvantage of the sample_type approach is that it generates more data and bloats the fast path.
If its useful it shouldn't live in a script anyway ;-) Also if the script muck can't deal with the side-band information its a worse broken piece of crap than I thought it was.
| |