Messages in this thread | | | From | Shuah Khan <> | Subject | Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow | Date | Tue, 30 Jul 2013 14:27:06 +0000 |
| |
On 07/30/2013 08:21 AM, Greg KH wrote: > On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote: >> Both H_IS and H_IE needs to be set to receive H_RDY >> interrupt >> >> 1. Assert H_IS to clear the interrupts during hw reset >> and use mei_me_reg_write instead of mei_hcsr_set as the later >> strips down the H_IS >> >> 2. fix interrupt disablement embarrassing typo >> hcsr |= ~H_IE -> hcsr &= ~H_IE; >> this will remove the unwanted interrupt on power down >> >> 3. remove useless debug print outs >> >> Cc: Shuah Khan <shuah.kh@samsung.com> >> Cc: Konstantin Khlebnikov <khlebnikov@openvz.org> >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> >> --- >> >> V2: Fixed typo in Shuah email >> >> Hope this finally resolve the ME reset issue for all > > Can I get a "Tested-by:" from someone to ensure that it really does > solve the problem? > > thanks, > > greg k-h >
I will test it on my system and let you know.
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research America (Silicon Valley) shuah.kh@samsung.com | (970) 672-0658
| |