lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 080/106] USB: EHCI: Fix resume signalling on remote wakeup
    Date
    3.5.7.18 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Roger Quadros <rogerq@ti.com>

    commit 47a64a13d54f6c669b00542848d5550be3d3310e upstream.

    Set the ehci->resuming flag for the port we receive a remote
    wakeup on so that resume signalling can be completed.

    Without this, the root hub timer will not fire again to check
    if the resume was completed and there will be a never-ending wait on
    on the port.

    This effect is only observed if the HUB IRQ IN does not come after we
    have initiated the port resume.

    Signed-off-by: Roger Quadros <rogerq@ti.com>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    [ luis: backported to 3.5: adjusted context ]
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/usb/host/ehci-hub.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
    index 349d3fe..c3a3a72 100644
    --- a/drivers/usb/host/ehci-hub.c
    +++ b/drivers/usb/host/ehci-hub.c
    @@ -827,6 +827,7 @@ static int ehci_hub_control (
    /* resume signaling for 20 msec */
    ehci->reset_done[wIndex] = jiffies
    + msecs_to_jiffies(20);
    + set_bit(wIndex, &ehci->resuming_ports);
    /* check the port again */
    mod_timer(&ehci_to_hcd(ehci)->rh_timer,
    ehci->reset_done[wIndex]);
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-07-30 12:01    [W:4.465 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site