lkml.org 
[lkml]   [2013]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: perf/Documentation/ABI -- add some documentation for perf_event sysfs usage
On Wed, 3 Jul 2013, Vince Weaver wrote:

>
> Add some documentation for the perf_event related
> /sys/bus/event_source/bus/devices/
> files, since in theory it's a stable interface and the only
> current documentation is some lex and yacc files in the
> perf tools directory.

OK, don't I feel silly, these values were already documented in
Documentation/ABI/testing/sysfs-bus-event_source-devices-events
rather than ABI/stable

To be fair I missed it because the documentation seemed to come from the
Power developers and not through perf_event

anyway, that documentation says the values will be hex only, which was
broken by

commit f9134f36aed59ab55c0ab1a4618dd455f15aef5f
Author: Andi Kleen <ak@linux.intel.com>
Date: Mon Jun 17 17:36:52 2013 -0700

perf/x86/intel: Add mem-loads/stores support for Haswell


which added:
EVENT_ATTR_STR(mem-loads, mem_ld_hsw, "event=0xcd,umask=0x1,ldlat=3");

(note ldlat is not in hex).

This broke the trinity fuzzer (which scans to look for events to use)
as well as some of my personal tools.

Should the ldlat value be fixed to be hex? Or should we ammend the ABI
document to allow decimal?

Vince


\
 
 \ /
  Last update: 2013-07-04 05:21    [W:0.101 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site