lkml.org 
[lkml]   [2013]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/4] ACPI / dock: Drop unnecessary local variable from dock_add()
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    The local variable id in dock_add() is not necessary, so drop it.

    While we're at it, use an initializer to clear the local variable ds
    and drop the memset() used for this purpose.

    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    ---
    drivers/acpi/dock.c | 9 ++++-----
    1 file changed, 4 insertions(+), 5 deletions(-)

    Index: linux-pm/drivers/acpi/dock.c
    ===================================================================
    --- linux-pm.orig/drivers/acpi/dock.c
    +++ linux-pm/drivers/acpi/dock.c
    @@ -836,14 +836,13 @@ static struct attribute_group dock_attri
    */
    static int __init dock_add(acpi_handle handle)
    {
    - int ret, id;
    - struct dock_station ds, *dock_station;
    + struct dock_station *dock_station, ds = { 0 };
    struct platform_device *dd;
    acpi_status status;
    + int ret;

    - id = dock_station_count;
    - memset(&ds, 0, sizeof(ds));
    - dd = platform_device_register_data(NULL, "dock", id, &ds, sizeof(ds));
    + dd = platform_device_register_data(NULL, "dock", dock_station_count,
    + &ds, sizeof(ds));
    if (IS_ERR(dd))
    return PTR_ERR(dd);



    \
     
     \ /
      Last update: 2013-07-04 01:41    [W:2.651 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site