Messages in this thread | | | Date | Wed, 3 Jul 2013 15:57:29 +0800 | From | Bo Shen <> | Subject | Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework |
| |
Hi Lars,
On 7/3/2013 15:36, Lars-Peter Clausen wrote: >>>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; >>> >>[...] >>>> >>>+ slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR; >>> >> >>> >>Change the type of phybase to dma_addr_t >> > >> >It should be: >> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR); >> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR); > The type of phybase in the ssc_device struct should be changed from > resource_size_t to dma_addr_t.
Actually, the phybase in ssc_device structure is resource_size_t which used to access the ssc device register. Here, we use ssc register as dma source address or destination address, so we convert it to dma_addr_t type. So, not need to change, am I right?
Best Regards, Bo Shen
| |