Messages in this thread | | | Date | Tue, 30 Jul 2013 11:04:53 +0800 | From | Li Zefan <> | Subject | Re: Checkpatch error on trace events macros |
| |
On 2013/7/30 10:36, Joe Perches wrote: > On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote: >> On 2013/7/30 9:58, Joe Perches wrote: >>> So what are these TRACE_<FOO> defines that need >>> excluding from the "complex values" check? >>> >>> Anything other than >>> >>> TRACE_SYSTEM >>> TRACE_INCLUDE_FILE >>> TRACE_INCLUDE_PATH >>> >>> ? >>> >>> samples/trace_events/trace-events-sample.h >>> only has those 3. >>> >> >> Try: >> # scripts/checkpatch.pl --file include/trace/events/* >> >> You'll see numerous errors. :) > > Nope, you'll see numerous whitespace defects, but no > actual errors. > > If you run with: > > --ignore=spacing,long_line,code_indent,leading_space,printf_l,split_string,space_before_tab,trailing_whitespace,line_continuations >
Serious? I'd just not run checkpatch.pl. ;)
> it's flawless. >
The "complex values" check complaints come from many places in include/trace/events/*, and I'm not going to check where and why.
| |