Messages in this thread | | | Date | Mon, 29 Jul 2013 14:31:39 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v3 3/8] cgroup: implement cgroup_from_id() |
| |
On Mon, Jul 29, 2013 at 03:08:15PM +0800, Li Zefan wrote: > +struct cgroup *cgroup_from_id(struct cgroup_subsys *ss, int id) > +{ > + rcu_lockdep_assert(rcu_read_lock_held(), > + "cgroup_from_id() needs rcu_read_lock()" > + " protection");
Maybe we want to add notation for &cgroup_mutex for completeness?
> + return idr_find(&ss->root->cgroup_idr, id); > +}
And maybe inline it?
Thanks.
-- tejun
| |