lkml.org 
[lkml]   [2013]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH v2 0/1] tracing: trace_remove_event_call() should fail if call/file is in use
Hello.

On top of "[PATCH v2 0/6] tracing: open/delete fixes" series.

Perhaps this series should be updated, Masami has some concerns.
But it seems that you both mostly agree with these changes, so
let me send the "last" patch for review.

The last change in kernel/trace/trace_events.c we need to close the
problems with create/use/delete (at least those which I know ;).

Now we are ready to change trace_kprobe.c and trace_uprobe.c, Steven
already has the patches.

Changes:

- remove the TRACE_EVENT_FL_REF_MASK (which we do not have)
check.

We rely on the previous changes, we do not care if someone
have an opened file, event_enable_write/etc can do nothing
but fail after we do remove_event_file_dir().

- Add the comment and a note into the changelog to explain
why we still need to check FTRACE_EVENT_FL_ENABLED.

Oleg.

include/linux/ftrace_event.h | 2 +-
kernel/trace/trace_events.c | 35 +++++++++++++++++++++++++++++++++--
2 files changed, 34 insertions(+), 3 deletions(-)



\
 
 \ /
  Last update: 2013-07-29 20:21    [W:0.079 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site