Messages in this thread | | | Date | Mon, 29 Jul 2013 17:58:43 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 2/4] usb: phy: add am335x pieces to generic phy |
| |
* Felipe Balbi | 2013-07-29 15:22:18 [+0300]:
>On Fri, Jul 26, 2013 at 10:15:55PM +0200, Sebastian Andrzej Siewior wrote: >> This patch copies the phy support bits from dsps into the generic phy >> driver. Most code can be re-used except for the on/off. >> The additional am335x can be removed once we have a phy driver that does >> more than this. >> >> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > >this is good too, but looking at the amount of am335x-specific code in >the driver now it makes me wonder if we want to convert phy-generic.c >into a library...
So I just looked over George Cherian phy driver. I think the simplest thing would be to add the usb wakeup path to the driver here. Earlier I hoped that we could just remove the am335x bits and avoid the library thingy :) Since the library probably makes sense: - before or after this patch - where do I get the memory for this wakeup register? It is somewhere in the "reset module" of the am335x
Sebastian
| |