lkml.org 
[lkml]   [2013]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [ 06/79] net: Swap ver and type in pppoe_hdr
From
From: Greg KH <gregkh@linuxfoundation.org>
Date: Sat, 27 Jul 2013 21:16:16 -0700

> On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote:
>> On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote:
>> > From: Ben Hutchings <ben@decadent.org.uk>
>> > Date: Sat, 27 Jul 2013 16:58:28 +0100
>> >
>> > > I'm not so sure this is suitable for stable. It doesn't seem to be
>> > > helpful to either userland or kernel code.
>> > >
>> > > In the kernel, we were checking that ver == 1 and type == 1 thus this
>> > > wasn't hurting us.
>> > >
>> > > If userland does anything more with these fields then it's probably
>> > > already working around the swapped fields. It can work with both old
>> > > and new headers by doing:
>> >
>> > It's up to you, I would rather have the corrected version propagated
>> > as soon as possible. But that's just me.
>>
>> Let's see what Greg thinks.
>
> I'm guessing that Linus's tree is also "wrong" here, correct? If so,
> the fix that goes into that tree should also go here as well.
>
> Or am I confused?

Linus's tree has had this change for a full release. It went into
3.10

It's correcting a mistake that has been there since the header
file even existed.



\
 
 \ /
  Last update: 2013-07-28 07:01    [W:0.100 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site