lkml.org 
[lkml]   [2013]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [ 06/79] net: Swap ver and type in pppoe_hdr
From
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sat, 27 Jul 2013 16:58:28 +0100

> I'm not so sure this is suitable for stable. It doesn't seem to be
> helpful to either userland or kernel code.
>
> In the kernel, we were checking that ver == 1 and type == 1 thus this
> wasn't hurting us.
>
> If userland does anything more with these fields then it's probably
> already working around the swapped fields. It can work with both old
> and new headers by doing:

It's up to you, I would rather have the corrected version propagated
as soon as possible. But that's just me.


\
 
 \ /
  Last update: 2013-07-28 03:21    [W:0.572 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site