Messages in this thread | | | Date | Sat, 27 Jul 2013 17:55:41 -0700 (PDT) | Subject | Re: [ 06/79] net: Swap ver and type in pppoe_hdr | From | David Miller <> |
| |
From: Ben Hutchings <ben@decadent.org.uk> Date: Sat, 27 Jul 2013 16:58:28 +0100
> I'm not so sure this is suitable for stable. It doesn't seem to be > helpful to either userland or kernel code. > > In the kernel, we were checking that ver == 1 and type == 1 thus this > wasn't hurting us. > > If userland does anything more with these fields then it's probably > already working around the swapped fields. It can work with both old > and new headers by doing:
It's up to you, I would rather have the corrected version propagated as soon as possible. But that's just me.
| |