Messages in this thread | | | Date | Fri, 26 Jul 2013 15:25:05 +0200 | From | Hans Verkuil <> | Subject | Re: [PATCH 4/4] [media] em28xx: Fix vidioc fmt vid cap v4l2 compliance |
| |
The change to g_fmt_vid_cap isn't necessary as that's automatically cleared. Only the s_fmt_vid_cap change is needed. I'll drop the first chunk and accept the second.
Thanks,
Hans
On 07/17/2013 01:06 AM, Alban Browaeys wrote: > Set fmt.pix.priv to zero in vidioc_g_fmt_vid_cap > and vidioc_try_fmt_vid_cap. > > Catched by v4l2-compliance. > > Signed-off-by: Alban Browaeys <prahal@yahoo.com> > --- > drivers/media/usb/em28xx/em28xx-video.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c > index 1a577ed..42930a4 100644 > --- a/drivers/media/usb/em28xx/em28xx-video.c > +++ b/drivers/media/usb/em28xx/em28xx-video.c > @@ -943,6 +943,8 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, > else > f->fmt.pix.field = dev->interlaced ? > V4L2_FIELD_INTERLACED : V4L2_FIELD_TOP; > + f->fmt.pix.priv = 0; > + > return 0; > } > > @@ -1008,6 +1010,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv, > else > f->fmt.pix.field = dev->interlaced ? > V4L2_FIELD_INTERLACED : V4L2_FIELD_TOP; > + f->fmt.pix.priv = 0; > > return 0; > } >
| |