Messages in this thread | | | Date | Thu, 25 Jul 2013 20:10:59 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error |
| |
On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote: > The function kirkwood_i2s_dev_remove() may be used when probe fails.
This seems fine but doesn't apply against current code but otherwise seems fine.
> + if (!IS_ERR(priv->extclk)) { > + clk_disable_unprepare(priv->extclk); > + clk_put(priv->extclk); > + }
Could use devm_clk_get() for extclk. [unhandled content-type:application/pgp-signature] | |