lkml.org 
[lkml]   [2013]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] ASoc: kirkwood: simplify probe error
On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote:
> The function kirkwood_i2s_dev_remove() may be used when probe fails.

This seems fine but doesn't apply against current code but otherwise
seems fine.

> + if (!IS_ERR(priv->extclk)) {
> + clk_disable_unprepare(priv->extclk);
> + clk_put(priv->extclk);
> + }

Could use devm_clk_get() for extclk.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-07-25 21:21    [W:0.083 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site