Messages in this thread | | | Subject | Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver. | From | Philipp Zabel <> | Date | Thu, 25 Jul 2013 19:34:53 +0200 |
| |
Hi Lee,
Am Donnerstag, den 25.07.2013, 09:08 +0100 schrieb Lee Jones: > > > Signed-off-by: Krystian Garbaciak <krystian.garbaciak@diasemi.com> > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > > --- > > > drivers/mfd/Kconfig | 12 + > > > drivers/mfd/Makefile | 3 + > > > drivers/mfd/da9063-core.c | 177 ++++++ > > > drivers/mfd/da9063-i2c.c | 197 ++++++ > > > drivers/mfd/da9063-irq.c | 193 ++++++ > > > include/linux/mfd/da9063/core.h | 110 ++++ > > > include/linux/mfd/da9063/pdata.h | 114 ++++ > > > include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++ > > > 8 files changed, 1896 insertions(+) > > > > Whoah!! Who's going to want to review a 2k line patch?
Well, most of those lines consist of the register and bit(field) definitions and the assignment of those to regmap and regmap-irq.
I could split this into (core+i2c) and (irq) parts if you insist.
> > Any chance you can split this stuff up into more 'bite sized' patches? > > You also missed Sam off the addressees list, which is not a good idea.
Oh right, thank you.
regards Philipp
| |