Messages in this thread | | | Date | Thu, 25 Jul 2013 10:49:54 +0800 | From | Michael Wang <> | Subject | Re: [PATCH v2] sched: update_top_cache_domain only at the times of building sched domain. |
| |
On 07/24/2013 06:49 PM, Peter Zijlstra wrote: > On Wed, Jul 24, 2013 at 04:34:39PM +0800, Michael Wang wrote: >> But your patch will run the risk to get a freed sd, since you make >> 'sd_llc' wrong for a period of time (between destroy and rebuild) IMO. >> >> I guess I get you point, you are trying to save one time update since >> you think this will be done twice, but actually the result of this two >> time update was different, it's not redo and it's in order to sync >> 'sd_llc' with 'rq->sd'. > > Michael is right, you cannot skip update_top_cache_domain() when > destroying things.
Thanks for the confirm :)
Regards, Michael Wang
> -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
| |