[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] regulator: palmas: fix pdata ptr not be updated after it has been allocated
On Wed, Jul 24, 2013 at 12:28:02PM -0400, Rhyland Klein wrote:

> + /* Store the pdata pointer after everything else passes */
> + pdev->dev.platform_data = pdata;

No, this is bad - the driver should not be modifying the platform_data
pointer, it's owned by the thing that created the device. If the
platform data needs to be modified it should be copied somewhere in the
driver data.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2013-07-24 19:41    [W:0.058 / U:28.232 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site