lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[59/85] nfsd4: fix decoding of compounds across page boundaries
    3.2.49-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "J. Bruce Fields" <bfields@redhat.com>

    commit 247500820ebd02ad87525db5d9b199e5b66f6636 upstream.

    A freebsd NFSv4.0 client was getting rare IO errors expanding a tarball.
    A network trace showed the server returning BAD_XDR on the final getattr
    of a getattr+write+getattr compound. The final getattr started on a
    page boundary.

    I believe the Linux client ignores errors on the post-write getattr, and
    that that's why we haven't seen this before.

    Reported-by: Rick Macklem <rmacklem@uoguelph.ca>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/nfsd/nfs4xdr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfsd/nfs4xdr.c
    +++ b/fs/nfsd/nfs4xdr.c
    @@ -177,8 +177,8 @@ static __be32 *read_buf(struct nfsd4_com
    */
    memcpy(p, argp->p, avail);
    /* step to next page */
    - argp->p = page_address(argp->pagelist[0]);
    argp->pagelist++;
    + argp->p = page_address(argp->pagelist[0]);
    if (argp->pagelen < PAGE_SIZE) {
    argp->end = argp->p + (argp->pagelen>>2);
    argp->pagelen = 0;


    \
     
     \ /
      Last update: 2013-07-24 17:21    [W:4.129 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site