Messages in this thread | | | Date | Wed, 24 Jul 2013 12:54:13 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/4] mfd: twl6030-irq: migrate to IRQ threaded handler |
| |
On Tue, 23 Jul 2013, Grygorii Strashko wrote:
> From: Naga Venkata Srikanth V <vnv.srikanth@samsung.com> > > 1) Removed request_irq() and replaced it with request_threaded_irq(). > > 2) Removed generic_handle_irq() and replaced it with > handle_nested_irq(). > Handling of these interrupts is nested, as we are handling an > interrupt (for e.g rtc, mmc1) when we are still servicing TWL irq. > > 3) Removed I2C read-retry logic for the case when twl_i2c_read() is > failed inside IRQ handler - there is no sense to do that, so just report > an error and return. > > Signed-off-by: Naga Venkata Srikanth V <vnv.srikanth@samsung.com> > Signed-off-by: Oleg_Kosheliev <oleg.kosheliev@ti.com> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/mfd/twl6030-irq.c | 146 +++++++++++++++------------------------------ > 1 file changed, 49 insertions(+), 97 deletions(-) > > diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
<snip>
> + status = request_threaded_irq(irq_num, NULL, twl6030_irq_thread, > + IRQF_ONESHOT, "TWL6030-PIH", NULL);
Oh, and please use managed resources for this: devm_*
> if (status < 0) { > dev_err(dev, "could not claim irq %d: %d\n", irq_num, status); > goto fail_irq; > } >
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |