[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] sched: update_top_cache_domain only at the times of building sched domain.
On Wed, Jul 24, 2013 at 04:34:39PM +0800, Michael Wang wrote:
> But your patch will run the risk to get a freed sd, since you make
> 'sd_llc' wrong for a period of time (between destroy and rebuild) IMO.
> I guess I get you point, you are trying to save one time update since
> you think this will be done twice, but actually the result of this two
> time update was different, it's not redo and it's in order to sync
> 'sd_llc' with 'rq->sd'.

Michael is right, you cannot skip update_top_cache_domain() when
destroying things.

 \ /
  Last update: 2013-07-24 13:21    [W:0.054 / U:1.424 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site