lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 027/103] ALSA: hda - Fix return value of snd_hda_check_power_state()
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 06ec56d3c60238f27bfa50d245592fccc1b4ef0f upstream.

    The refactoring by commit 9040d102 introduced the new function
    snd_hda_check_power_state(). This function is supposed to return true
    if the state already reached to the target state, but it actually
    returns false for that. An utterly stupid typo while copy & paste.

    Fortunately this didn't influence on much behavior because powering up
    AFG usually powers up the child widgets, too. But the finer power
    control must have been broken by this bug.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/hda_local.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/pci/hda/hda_local.h
    +++ b/sound/pci/hda/hda_local.h
    @@ -667,7 +667,7 @@ snd_hda_check_power_state(struct hda_cod
    if (state & AC_PWRST_ERROR)
    return true;
    state = (state >> 4) & 0x0f;
    - return (state != target_state);
    + return (state == target_state);
    }

    unsigned int snd_hda_codec_eapd_power_filter(struct hda_codec *codec,



    \
     
     \ /
      Last update: 2013-07-24 04:21    [W:4.041 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site