| Date | Tue, 23 Jul 2013 14:48:43 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT. |
| |
On Fri, Jul 19, 2013 at 03:59:14PM +0800, Tang Chen wrote: > The Hot-Pluggable field in SRAT suggests if the memory could be > hotplugged while the system is running. Print it as well when > parsing SRAT will help users to know which memory is hotpluggable. > > Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> > Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Acked-by: Tejun Heo <tj@kernel.org>
But a nit below
> + pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx] %s\n", > + node, pxm, > + (unsigned long long) start, (unsigned long long) end - 1, > + hotpluggable ? "Hot Pluggable" : "");
The following would be more conventional.
"...10Lx]%s\n", ..., hotpluggable ? " Hot Pluggable" : ""
Also, isn't "Hot Pluggable" a bit too verbose? "hotplug" should be fine, I think.
Thanks.
-- tejun
|