Messages in this thread | | | Date | Tue, 23 Jul 2013 15:12:56 +0200 | From | Sebastian Hesselbarth <> | Subject | Re: [alsa-devel] [PATCH] ARM: kirkwood: enable S/PDIF |
| |
On 07/23/13 15:06, Mark Brown wrote: > On Tue, Jul 23, 2013 at 09:43:47AM +0100, Russell King - ARM Linux wrote: >> On Tue, Jul 23, 2013 at 10:23:20AM +0200, Jean-Francois Moine wrote: >>> This patch enables S/PDIF. > >>> Signed-off-by: Jean-Francois Moine <moinejf@free.fr> > >> I'm not submitting my patch to do this because: > >> (a) we don't know what effect this has on other hardware. > > This patch will do absolutely nothing unless it's used in a machine > driver which connects a S/PDIF CODEC to it. I see no reason not to > apply it, someone with hardware with more complex needs can always build > on it later. >
Mark,
the mask that is changed in the patch is what will be written into i2s controller's registers. So, if there is no S/PDIF in that specific controller that bit can possibly have a different meaning. Also, enabling both I2S playback and SPDIF playback can cause the controller to behave differently.
I share Russell's concern about it and would rather like to use multiple codecs per DAI (DPCM) for that. I see Daniel Mack picked that up again, maybe he submits something soon.
Sebastian
| |