lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, acpi: Remove out-of-date comment of __acpi_map_table
On 07/23/2013 05:22 PM, Ingo Molnar wrote:
>
> * Zhang Yanfei <zhangyanfei.yes@gmail.com> wrote:
>
>> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>>
>> The implementation of function __acpi_map_table() has been changed
>> long time ago, and now it directly invokes early_ioremap() to setup
>> the temporarily acpi table mappings. So remove its out-of-date
>> comment.
>>
>> Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>> ---
>> arch/x86/kernel/acpi/boot.c | 13 +------------
>> 1 files changed, 1 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
>> index d81a972..bac8b5b 100644
>> --- a/arch/x86/kernel/acpi/boot.c
>> +++ b/arch/x86/kernel/acpi/boot.c
>> @@ -140,18 +140,6 @@ static u32 irq_to_gsi(int irq)
>> return gsi;
>> }
>>
>> -/*
>> - * Temporarily use the virtual area starting from FIX_IO_APIC_BASE_END,
>> - * to map the target physical address. The problem is that set_fixmap()
>> - * provides a single page, and it is possible that the page is not
>> - * sufficient.
>> - * By using this area, we can map up to MAX_IO_APICS pages temporarily,
>> - * i.e. until the next __va_range() call.
>> - *
>> - * Important Safety Note: The fixed I/O APIC page numbers are *subtracted*
>> - * from the fixed base. That's why we start at FIX_IO_APIC_BASE_END and
>> - * count idx down while incrementing the phys address.
>> - */
>> char *__init __acpi_map_table(unsigned long phys, unsigned long size)
>
> Good catch. Removing documentation makes me sad, so how about replacing it
> with a simple comment:
>
> /*
> * This is just a simple wrapper around early_ioremap(),
> * with sanity checks for phys == 0 and size == 0:
> */
>
> ?

Yeah, agreed. So I will send the v2 patch.

>
> Thanks,
>
> Ingo


--
Thanks.
Zhang Yanfei


\
 
 \ /
  Last update: 2013-07-23 15:21    [W:0.130 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site