lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage
On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote:

> + np = pdev->dev.of_node;
> + if (np) {
> + struct of_phandle_args clkspec;
> +
> + priv->burst = 128; /* might be 32 or 128 */

The comment says this needs to be variable (depending on what?) but it's
hard coded.

> + priv->clk = of_clk_get(np, 0); /* internal clock */
> + err = of_parse_phandle_with_args(np,
> + "clocks", "#clock-cells", 1,
> + &clkspec);

As others have pointed out if you need to change the clock get code
there's something wrong here, DT should be handled transparently by the
clock API.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-07-23 15:01    [W:0.144 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site