lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC] regmap: core: allow a virtual range to cover its own data window
    Date
    I see no reason why a virtual range shouldn't be allowed to cover its
    own data window if the page selection register is in the same place
    on every page.
    For chips which use paged access for all of their registers, but only
    when connected via I2C, and which can access the whole register space
    directly when connected via SPI, this allows to avoid acrobatics with
    the register ranges by simply mapping the I2C ranges over the data
    window beginning at 0x0, and then using linear access for the SPI
    variant.

    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

    ---
    I am looking at DA9063, which could use the following range
    configuration for the I2C variant:

    struct regmap_range_cfg da9063_i2c_regmap_ranges[] = {
    {
    .range_min = 0x00,
    .range_max = 0x1ff,
    .selector_reg = 0x00,
    .selector_mask = 0x03,
    .selector_shift = 1,
    .window_start = 0x00,
    .window_len = 0x100,
    },
    };

    /* no da9063_spi_regmap_ranges needed */
    ---
    drivers/base/regmap/regmap.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
    index 9592058..1205d8c 100644
    --- a/drivers/base/regmap/regmap.c
    +++ b/drivers/base/regmap/regmap.c
    @@ -687,6 +687,10 @@ skip_format_initialization:
    unsigned win_max = win_min +
    config->ranges[j].window_len - 1;

    + /* Allow data window inside its own virtual range */
    + if (j == i)
    + continue;
    +
    if (range_cfg->range_min <= sel_reg &&
    sel_reg <= range_cfg->range_max) {
    dev_err(map->dev,
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-07-23 13:01    [W:0.025 / U:121.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site