lkml.org 
[lkml]   [2013]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: crypto: ux500: Fix logging, make arrays const, neatening
From
On Tue, Jul 16, 2013 at 11:06 PM, Joe Perches <joe@perches.com> wrote:

> Logging messages without newlines are possibly interleaved
> with other messages. Add terminating newlines to avoid
> this.
>
> Other miscellaneous changes:
>
> Make arrays const to reduce data size
> Add pr_fmt to prefix pr_<level>, remove now unused DEV_DBG_NAME
> Coalesce formats, align arguments
> Remove unnecessary OOM messages as dump_stack is already done
> Remove unnecessary cast of void *
> Change kzalloc(sizeof(struct)...) to kzalloc(sizeof(*var), ...)
> Reduce indents in struct definitions
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> On top of Masanari Iida's patch:
> https://patchwork.kernel.org/patch/2828273/

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Have you tested this on hardware or is it compile-tested only?

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-07-23 01:21    [W:0.058 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site