Messages in this thread |  | | Date | Mon, 22 Jul 2013 16:55:41 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH 5/9] mm, hugetlb: remove redundant list_empty check in gather_surplus_pages() |
| |
On Mon 15-07-13 18:52:43, Joonsoo Kim wrote: > If list is empty, list_for_each_entry_safe() doesn't do anything. > So, this check is redundant. Remove it. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
> > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index a838e6b..d4a1695 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1019,10 +1019,8 @@ free: > spin_unlock(&hugetlb_lock); > > /* Free unnecessary surplus pages to the buddy allocator */ > - if (!list_empty(&surplus_list)) { > - list_for_each_entry_safe(page, tmp, &surplus_list, lru) { > - put_page(page); > - } > + list_for_each_entry_safe(page, tmp, &surplus_list, lru) { > + put_page(page); > } > spin_lock(&hugetlb_lock); > > -- > 1.7.9.5 >
-- Michal Hocko SUSE Labs
|  |