lkml.org 
[lkml]   [2013]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] xen/arm: enable PV control for ARM
On Mon, 22 Jul 2013, Mark Rutland wrote:
> Hi,
>
> [Adding Catalin to Cc]
>
> On Mon, Jul 22, 2013 at 11:57:34AM +0100, Julien Grall wrote:
> > Enable power management from the toolstack for ARM guest.
> >
> > Signed-off-by: Julien Grall <julien.grall@linaro.org>
> >
> > ---
> > Changes in v3:
> > - Fix condition to compile cpu_hotplug.o
> > Changes in v2:
> > - Don't compile xen/cpu_hotplug.o with ARM64
>
> My arm64 cpu hotplug series is going to be dependent on not compiling
> xen/cpu_hotplug.o. Currently I'm not able to compile an arm64 kernel
> with my patches and Xen support.
>
> How do you intend to push this? I'd like to ensure my cpu hotplug series
> is able to go in for the next merge window.

This patch does exactly that: it makes sure cpu_hotplug is not compiled
on ARM64.
Given that this patch is for drivers/xen/Makefile, normally it goes via
Konrad's tree.


> > ---
> > drivers/xen/Makefile | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> > index 2bf461a..f185e8d 100644
> > --- a/drivers/xen/Makefile
> > +++ b/drivers/xen/Makefile
> > @@ -1,9 +1,8 @@
> > -ifneq ($(CONFIG_ARM),y)
> > -obj-y += manage.o
> > +ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> > obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> > endif
>
> Might it make sense to enable this based on a list the architectures
> that actually need this, rather than disabling it based on the list of
> architectures that don't?

This is more philosophical than practical, but I would expect this
limitation to go away soon, and be able to compile cpu_hotplug without
issues on ARM and ARM64 too.


\
 
 \ /
  Last update: 2013-07-22 16:42    [W:0.063 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site