Messages in this thread Patch in this message | | | From | Joonsoo Kim <> | Subject | [PATCH v2 06/10] mm, hugetlb: remove redundant list_empty check in gather_surplus_pages() | Date | Mon, 22 Jul 2013 17:36:27 +0900 |
| |
If list is empty, list_for_each_entry_safe() doesn't do anything. So, this check is redundant. Remove it.
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 3ac0a6f..7ca8733 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -1017,11 +1017,8 @@ free: spin_unlock(&hugetlb_lock); /* Free unnecessary surplus pages to the buddy allocator */ - if (!list_empty(&surplus_list)) { - list_for_each_entry_safe(page, tmp, &surplus_list, lru) { - put_page(page); - } - } + list_for_each_entry_safe(page, tmp, &surplus_list, lru) + put_page(page); spin_lock(&hugetlb_lock); return ret; -- 1.7.9.5
| |