Messages in this thread | | | From | "Kim, Milo" <> | Subject | RE: [PATCH 2/3] gpio: add LP3943 I2C GPIO expander driver | Date | Mon, 22 Jul 2013 01:19:25 +0000 |
| |
Hi Linus, Thanks for both of GPIO patch reviews. I'll fix them.
> I forgot one thing: > > On Tue, Jul 16, 2013 at 4:38 AM, Kim, Milo <Milo.Kim@ti.com> wrote: > > > +static int lp3943_gpio_probe(struct platform_device *pdev) > > +{ > > + struct lp3943 *l = dev_get_drvdata(pdev->dev.parent); > > + struct lp3943_gpio *lg; > > + int ret; > > This is where I want you to assign to a member of struct > lp3943 another u16 mask which tells which lines are > actually available for GPIO, and you should also add code to > make sure that lines that are not available fail gpio_request(). > > This configuration can probably be read out from the device > tree if you add the compatible node to the MFD cell when > registering it. > > Yours, > Linus Walleij
Regards, Milo
| |