Messages in this thread | | | Date | Tue, 2 Jul 2013 17:50:29 -0700 | Subject | Re: [GIT PULL] perf changes for v3.11 | From | Linus Torvalds <> |
| |
On Mon, Jul 1, 2013 at 2:03 AM, Ingo Molnar <mingo@kernel.org> wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-core-for-linus > > Kernel improvements: > > * AMD IOMMU uncore PMU support by Suravee Suthikulpanit001a
This one prints a really annoying error message if you're not on an AMD platform:
+ if (!amd_iommu_pc_supported()) { + pr_err("perf: amd_iommu PMU not installed. No support!\n"); + return -ENODEV; + }
and you know what? That's not acceptable. It damn well is *not* an error to not have an AMD IOMMU.
It should - at most - be a pr_info(). Maybe nothing at all. "pr_err()" is just totally out of line.
Linus
| |