lkml.org 
[lkml]   [2013]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [GIT PULL] perf changes for v3.11
From
On Mon, Jul 1, 2013 at 2:03 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-core-for-linus
>
> Kernel improvements:
>
> * AMD IOMMU uncore PMU support by Suravee Suthikulpanit001a

This one prints a really annoying error message if you're not on an
AMD platform:

+ if (!amd_iommu_pc_supported()) {
+ pr_err("perf: amd_iommu PMU not installed. No support!\n");
+ return -ENODEV;
+ }

and you know what? That's not acceptable. It damn well is *not* an
error to not have an AMD IOMMU.

It should - at most - be a pr_info(). Maybe nothing at all. "pr_err()"
is just totally out of line.

Linus


\
 
 \ /
  Last update: 2013-07-03 03:21    [W:0.104 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site