Messages in this thread | | | Date | Tue, 2 Jul 2013 22:01:47 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate |
| |
On 07/01, Denys Vlasenko wrote: > > Grepping for numeric constants is inconvenient.
Personally I agree very much, and I like the intent.
> +#define WTERMSIG_MASK 0x7f > +#define WTERMSIG(status) ((status) & WTERMSIG_MASK) > +#define WCOREDUMP(status) ((status) & 0x80)
But I am not sure we need WTERMSIG/WCOREDUMP helpers, although I won't really argue.
OTOH, I think it would be nice to add the name for 0x80 and change coredump_finish().
And if we do not add WTERMSIG(), then perhaps we can turn other 0x7f's into WTERMSIG_MASK?
Oleg.
| |