lkml.org 
[lkml]   [2013]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX
Hi,

On Friday 19 July 2013 06:04 PM, George Cherian wrote:
> Add phy nodes for AM33XX platform and split the musb nodes
> per instance.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 68 +++++++++++++++++++++++++++++++++----------
> 1 file changed, 53 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 8e1248f..e3890c4 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -326,21 +326,59 @@
> status = "disabled";
> };
>
> - usb@47400000 {
> - compatible = "ti,musb-am33xx";
> - reg = <0x47400000 0x1000 /* usbss */
> - 0x47401000 0x800 /* musb instance 0 */
> - 0x47401800 0x800>; /* musb instance 1 */
> - interrupts = <17 /* usbss */
> - 18 /* musb instance 0 */
> - 19>; /* musb instance 1 */
> - multipoint = <1>;
> - num-eps = <16>;
> - ram-bits = <12>;
> - port0-mode = <3>;
> - port1-mode = <3>;
> - power = <250>;
> - ti,hwmods = "usb_otg_hs";
> + phy1: am335x-usb0@44e10620 {

*44e10620* is not needed if you are not having the reg property.
> + compatible = "ti,am335x-usb2";
> + #phy-cells = <0>;
> + id= <0>;
> + };
> +
> + phy2: am335x-usb1@44e10628 {
> + compatible = "ti,am335x-usb2";

ditto..
> + #phy-cells = <0>;
> + id= <1>;
> + };
> +
> + omap_control_usb: omap-control-usb@44e10620 {
> + compatible = "ti,omap-control-usb";
> + reg = <0x44e10620 0x10>;
> + reg-names = "control_dev_conf";
> + ti,type = <3>;
> + };
> +
> + musb: usb@47400000 {
> + compatible = "ti,musb-am33xx";
> + reg = <0x47400000 0x1000>;
> + ranges;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + interrupts = <17>;
> + ti,hwmods = "usb_otg_hs";
> +
> + usb0@47401000 {
> + reg = <0x47401000 0x800>;
> + interrupts = <18>;
> + interrupt-names = "mc";
> + multipoint = <1>;
> + num-eps = <16>;
> + ram-bits = <12>;
> + port-mode = <3>;
> + power = <250>;
> + phys = <&phy1>;
> + phy-names = "am335x-usb0";

Looks like alignment has gone wrong here.
> + };
> +
> + usb1@47401800 {
> + reg = <0x47401800 0x800>;
> + interrupts = <19>;
> + interrupt-names = "mc";
> + multipoint = <1>;
> + num-eps = <16>;
> + ram-bits = <12>;
> + port-mode = <3>;
> + power = <250>;
> + phys = <&phy2>;
> + phy-names = "am335x-usb1";
ditto.

Thanks
Kishon


\
 
 \ /
  Last update: 2013-07-19 16:01    [W:0.342 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site