| From | Namhyung Kim <> | Subject | Re: [PATCH 02/23] perf tools: Remove data_offset seek as it's not needed | Date | Thu, 18 Jul 2013 16:27:47 +0900 |
| |
On Wed, 17 Jul 2013 19:49:42 +0200, Jiri Olsa wrote: > Removing data_offset seek as it's not needed, because > data are not read by syscall but mmaped instead.
Yes we do, but it's not mandatory, right? I'd rather expect the file offset remains at the beginning of data after calling perf_session__read_header() instead of a random point (EOF?).
Thanks, Namhyung
|