lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 02/23] perf tools: Remove data_offset seek as it's not needed
Date
On Wed, 17 Jul 2013 19:49:42 +0200, Jiri Olsa wrote:
> Removing data_offset seek as it's not needed, because
> data are not read by syscall but mmaped instead.

Yes we do, but it's not mandatory, right? I'd rather expect the file
offset remains at the beginning of data after calling
perf_session__read_header() instead of a random point (EOF?).

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-07-18 09:41    [W:0.601 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site