lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/urgent] x86: Make sure IDT is page aligned

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 07/17/2013 11:57 AM, Yinghai Lu wrote:
> >
> > Hi, Peter,
> >
> > Any reason for why following changelog get dropped?
> >
> > ---
> > v5:
> > - add comments to all IDTs about alignment reasoning, suggested by Linus
> > v4:
> > - rework using __page_aligned_bss, suggested by Yinghai LU
> > - move all the other IDT variables as well, suggested by HPA
> > v3:
> > - merge 32-bit and 64-bit idt_table definition
> > v2:
> > - 32-bit was already aligned
> > ---
> >
> > That at least would help us to check if you apply the right version.
> >
>
> Procedurally, the changelogs don't belong in commit messages. I tend to
> leave them in if they are particularly illustrative or if the commit
> message only makes sense with the additional context, but neither of
> those is really ideal.
>
> Technically, because of the --- line which indicates the end of the
> commit message.

Furthermote, the -tip notification email will generally email-thread on
lkml to the patch submission that was applied.

That is a more robust indication of which submission was applied than any
changelog detail.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-07-18 09:41    [W:0.053 / U:3.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site