lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectperf: support for named threads broken
Hi Feng:

I noticed today that support for named threads is busted in latest perf.
git bisect shows the first bad commit as:

commit 73994dc158a24df4af77d0a76c9702f120f7a6ad
Author: Feng Tang <feng.tang@intel.com>
Date: Wed Aug 8 17:57:52 2012 +0800

perf script: Replace "struct thread" with "struct addr_location" as
a parameter for "process_event()"

Both perl and python script start processing events other than trace
points, and it's useful to pass the resolved symbol and the dso info to
the event handler in script for better analysis and statistics.

Struct thread is already a member of struct addr_location, using
addr_location will keep the thread info, while providing additional
symbol and dso info if exist, so that the script itself doesn't need to
bother to do the symbol resolving and dso searching work.


I conveniently cut-off the Tested-by and Acked-by from me ;-)
Clearly I did not test named threads.

Can you take a look?

David


\
 
 \ /
  Last update: 2013-07-18 23:41    [W:0.051 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site