lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 02/51] Input: atmel_mxt_ts - Improve T19 GPIO keys handling
On Thu, Jun 27, 2013 at 01:48:37PM +0100, Nick Dyer wrote:
>
> * The mapping of the GPIO numbers into the T19 status byte varies between
> different maXTouch chips. Some have up to 7 GPIOs. Allowing a keycode array
> of up to 8 items is simpler and more generic. So replace #define with
> configurable number of keys which also allows the removal of is_tp.
> * Rename platform data parameters to include "t19" to prevent confusion with
> T15 key array.
> * Probe aborts early on when pdata is NULL, so no need to check.
> * Move "int i" to beginning of function (mixed declarations and code)
> * Use API calls rather than __set_bit()
> * Remove unused dev variable.
>
> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 44 ++++++++++++------------------
> drivers/platform/x86/chromeos_laptop.c | 17 ++++++++----
> include/linux/i2c/atmel_mxt_ts.h | 7 ++---
> 3 files changed, 30 insertions(+), 38 deletions(-)

Reviewed-by: Henrik Rydberg <rydberg@euromail.se>

Thanks,
Henrik


\
 
 \ /
  Last update: 2013-07-18 19:41    [W:1.287 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site