Messages in this thread | | | Date | Thu, 18 Jul 2013 14:46:01 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 02/23] perf tools: Remove data_offset seek as it's not needed |
| |
On Thu, Jul 18, 2013 at 04:27:47PM +0900, Namhyung Kim wrote: > On Wed, 17 Jul 2013 19:49:42 +0200, Jiri Olsa wrote: > > Removing data_offset seek as it's not needed, because > > data are not read by syscall but mmaped instead. > > Yes we do, but it's not mandatory, right? I'd rather expect the file > offset remains at the beginning of data after calling > perf_session__read_header() instead of a random point (EOF?).
well it's just useless, and I think it's better and more clear to set it properly before the reading anyway. Also AFAICS there's no other read after this seek even later.
jirka
| |