Messages in this thread | | | Date | Thu, 18 Jul 2013 21:07:21 +0900 | From | Masami Hiramatsu <> | Subject | Re: [RFC PATCH V2] tracing/kprobe: Wait for disabling all running kprobe handlers |
| |
(2013/07/16 3:20), Oleg Nesterov wrote: > On 07/09, Masami Hiramatsu wrote: >> >> Wait for disabling all running kprobe handlers when a kprobe >> event is disabled, since the caller, trace_remove_event_call() >> supposes that a removing event is disabled completely by >> disabling the event. >> With this change, ftrace can ensure that there is no running >> event handlers after disabling it. >> >> Changes in V2: >> - Comment (in code) for clarify why we need to wait there. >> >> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > > Agreed. > > We need this change in any case, whatever we do in trace/trace_events.c > and in unregister_trace_probe().
Steven, I think this patch is still needed anyway even if we are discussing file handling bugs, because this fixes another timing bug.
Thank you,
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |