Messages in this thread | | | Date | Wed, 17 Jul 2013 08:33:02 -0400 (EDT) | From | Nicolas Pitre <> | Subject | Re: [RFC PATCH v5 0/1] drivers: mfd: Versatile Express SPC support |
| |
On Wed, 17 Jul 2013, Pawel Moll wrote:
> On Tue, 2013-07-16 at 17:05 +0100, Lorenzo Pieralisi wrote: > > /drivers/mfd is probably not the right place for this code as it stands (but > > probably will be when the entire driver, with DVFS and config interface, is > > complete). > > Not that it really matters now, but my vexpress-sysreg rework will - > most likely - leave only skeleton in the MFD (registering mfd_cells) and > other stuff is going to be spread all around. Then I'm planning to move > the remaining of the vexpress-specific initialization to > drivers/platform/arm/vexpress.c, so maybe sticking vexpress-spc.c to > this (non-existing yet) directory would be the right thing to do?
I don't like this idea. We worked hard to shrink platform specific directories such as arch/arm/mach-*/ as much as possible. Simply moving stuff to drivers/platform/arm/* doesn't make the situation any much better.
If this is really miscelaneous code that really doesn't fit anywhere else, it should rather go into drivers/misc/ as a last resort.
Nicolas
| |